On Mon, Feb 02, 2009 at 03:42:17AM -0800, Dan Price wrote:
> http://cr.opensolaris.org/~dp/deploy-fixes
setup.py:
- line 392: will the use of -R/usr/sfw/lib put this in the openssl
modules even on systems where it's not required? Or are you simply
depending on the fact that we're now using the pyopenssl delivered in
Nevada as of build 106?
- line 490: this seems a bit sketchy. Why is it okay to do this here?
Does the call to byte_compile() in distutils.build_py.build_py.run()
recompile everything anyway? Do we end up with the right paths in the
.pyc files with and without PRIVATE_BUILD set?
- line 491: why not catch a PyCompileError?
- line 494: you don't need the str() call here.
svc-pkg-depot:
- line 119: you don't need to fork off grep to do these checks. This and
the two ssl-key-file ones can simply be done with
[[ $bool_ops == *'--readonly'* ]]
and I'm pretty sure you can do the ssl-dialog check with
[[ $option_ops == *--ssl-dialog=@(smf|exec):* ]]
which should work with ksh88, too. Maybe a "+" instead of the "@".
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
