On Mon 02 Feb 2009 at 09:01AM, Danek Duvall wrote:
> Looks like 6303 and 3821 are duplicates.
>
> src/Makefile:
>
> - line 55: Why bother having this line?
Sorry, it wasn't intended to be commented out. I had done that
for some testing and fixed it shortly after publishing the webrev.
> src/um/Makefile:
>
> - line 136: Does this blank line prevent the following commented-out
> lines from ever getting printed out?
Yes. I didn't want to delete it, but I also didn't want it to print
out to the console every time.
> - line 152ff: This is almost $(ROOTCOMPONENTS); would it be worth using a
> common variable so you don't have to remember to update both places,
> and remember what belongs in one and not the other?
Fixed in both UM and GUI.
> - line 194: Could $(ROOTAPPICONSHARE) be $(@D) here and in the other
> rules? That might also allow you to combine the rules into a smaller
> set, if you cared to.
Could be-- I was wary of too much merging of rules. I'm going to
leave as is.
Thanks for the review.
-dp
--
Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
