General comments:
What, if any, assumptions are being builtin because, right now, dynamic
update of this start page isn't a requirement? Ie, if marketing came
back tomorrow and said "we need dynamic update" which bits of existing
code would have to be rewhacked? Personally, I see little point in a
static splash page while a dynamic one could have some real use I would
think.
packagemanager.py:
It would be nice if START_PAGE_BASE simply filled in the slot of
START_PAGE_LANG_BASE with an appropriate value ("default"?) rather than
duplicating the path, that way if the files moved from usr/share to
something else, there's a single point of change.
Same comment for START_PAGE_HOME, that should probably be used to
substitute into the two other variables.
line 169:
Shouldn't self.in_startpage_startup be equal to show_startpage?
182:
remove spaces
381-397:
Is there a reason that the "C" language isn't used as the default start
page? That's what lines 366-373 seem to be establishing anyway. Given
those lines, can't we declare the C locale to be the default and just
dump lines 384-386?
437:
I think this should be moved above the try block.
463-470:
Given that only one substitution happens outside of html code, using
straight % substitution here is probably ok, though I would like someone
with more html/internationalization experience to verify that for me.
476-477 and 504-509:
Why ignore links without pm-action instead of treating them (for
example) as external links?
484-498 and 515-538 sure look similar, maybe there's some commonality to
be extracted from them?
Thanks,
Brock
jmr wrote:
> Hi following is a webrev for changes to PM,
>
> http://cr.opensolaris.org/~jmr/pm_startpage_only_gate_Feb04/
>
> Enhancement: 6355: Add StartPage to PM
>
> Also folded in one line change for Bug: 6269: PackageManager does not
> quit after cancel update
>
> JR
>
>
> Change Summary 6355:
> Start Page
> -----------------
> In line with other desktop apps like NetBeans and Thunderbird a StartPage is
> being added to the PM.
>
> On startup the StartPage is displayed where the package list is displayed.
> - If a user starts searching, or switches categories the list view
> replaces the
> StartPage.
> - The user can always get back to the StartPage from the Help->Start
> Page menu
> item.
> - A Preferences Dialog will be added to allow a user to turn off display
> of the
> StartPage on startup if they wish (refer to bug 6354
> <http://defect.opensolaris.org/bz/show_bug.cgi?id=6354>). They can do so
> now by
> modifying a gconf key setting.
>
> The StartPage is a placeholder that marketing can modify as they see fit
> before
> a release. At present there is no plans to dynamically modify the page.
>
> The StartPage is hosted in a simple HTML renderer control that just
> allows HTML
> to be displayed, along with images and CSS support. There is no scripting
> support.
> At present links can be added to the page to allow browsing within the
> StartPage pane or externally by launching the default browser. At
> present the
> internal browse is only used to handle error conditions and the main
> StartPage
> has images which are all linked to external OpenSolaris web pages.
>
> It is envisaged that this static Start Page will bring users to specific
> OpenSolaris properites and by having ips MimeType support on the server
> (refer
> to bug 6352 <http://defect.opensolaris.org/bz/show_bug.cgi?id=6352>) the
> user will be able to add additional repos and/or packages by
> just clicking on links on these external web pages.
>
>
> _______________________________________________
> pkg-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
>
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
