Padraig O'Briain wrote: > > On 02/05/09 12:42, Michal Pryc wrote: >> Padraig, >> >> http://cr.opensolaris.org/~padraig/ips-4578-v1/src/packagemanager.py.wdiff.html >> >> >> 2103-2104: >> Is it necessary to do the check before removing? >> What about instead those two lines: >> self.info_cache.pop(pkg_stem) >> > I think that it is necessary to do the check as the size of the cache > could have reached MAX_INFO_CACHE_LIMIT and the cache could have been > contracted. > I could replace 2104 with self.info_cache.pop(pkg_stem). I think del is fine then.
best Michal > > Padraig >> Michal >> >> Padraig O'Briain wrote: >>> The webrev http://cr.opensolaris.org/~padraig/ips-4578-v1/ fixes >>> 4578 IPS GUI does not update the package info after upgrading >>> >>> The details of the packages which are installed or removed are removed >>> from the cache and the >>> details for the selected package are then redisplayed. >>> _______________________________________________ >>> pkg-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
