Same - just reviewed it with Padraig +1 JR
Michal Pryc wrote: > I have been talking with Padraig offline about this webrev and it looks > good to me. > > best > Michal > > Padraig O'Briain wrote: > >> I have updated the webrev, >> http://cr.opensolaris.org/~padraig/ips-5398-v2/, to address Brock's >> comments. >> >> Padraig >> >> >> >> On 02/04/09 22:29, Brock Pytlik wrote: >> >>> installupdate.py >>> Since you're near here anyway, please change "wan't" to "want" on line >>> 351 >>> >>> updatemanager.py: >>> 934-937 remove commented lines please >>> >>> Brock >>> >>> Padraig O'Briain wrote: >>> >>>> The webrev http://cr.opensolaris.org/~padraig/ips-5398-v1/ fixes two >>>> bugs >>>> 5398 UM not following steps consistently >>>> 5248 Updatemanager should handle installing SUNWipkg when needed >>>> >>>> The solution is to have UpdateManager use the InstallUpdate class >>>> from PackageManager to do the image update. This ensure that the user >>>> experience will be the same in UpdateManager as it is in PackageManager. >>>> >>>> Padraig >>>> _______________________________________________ >>>> pkg-discuss mailing list >>>> [email protected] >>>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >>>> >>>> >> _______________________________________________ >> pkg-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >> > > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
