Brock,
> Webrev:
> http://cr.opensolaris.org/~bpytlik/ips-6712-v1/
>
> Bug:
> 6712 search shouldn't index actions for other variants of an image
> http://defect.opensolaris.org/bz/show_bug.cgi?id=6712
Just a few questions:
indexer.py:
- line 396: Is this redundant? Or is fmri_list not a list? If not,
should we name it something less confusing?
server/catalog.py:
- line 291: Do we need EnvironmentError exception handling here?
- Nit: It seems a little confusing to have both image.get_manifest and
catalog.get_manifest. After looking at server/catalog.py, I now
understand why you made this an argument to the indexer. Should
these functions have different names to make it a bit clearer that
one belongs on the serverside and the other belongs to the image? I
understand that we can infer this by looking at the object that's
defining the function, but I thought I'd ask anyway.
Looks good otherwise.
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
