> I have reworked the webrev, 
> http://cr.opensolaris.org/~padraig/ips-6549-v3/, to remove all calls to 
> beadm.

This looks a lot better.  Just a few more comments:

- line 529: This looks like an extra return statement

- lines 528, 532: Does the BE code ever raise an exception, or are all
  errors returned in a numerical code?

-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to