Danek Duvall wrote:
Ed managed to get himself into a situation where a legacy action was
broken, and "pkg fix" was stacktracing. There's a simple one-liner fix
that I've just put into the bug report if anyone wants to look at it:
http://defect.opensolaris.org/bz/show_bug.cgi?id=7907
Minor nitpick, instead of using self.destination_fmri.version, why not
use fmri.version and avoid the extra de-reference since it's insc ope?
Other than that, this looks fine to me. I also checked all the other
propose methods and where this was being used...
However, there appears to be one more bug here related to legacy
information (not in your changeset):
modules/actions/legacy.py: line 69:
This assumes that svr4 packages will always be arch i386; but isn't
this false now that we support SPARC as well?
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
