Michal,

I've logged:
7921 PM should handle gconf lookup failures gracefully

Which is what your webrev is fixing. With this putback I think the severity of 7852 can be dropped to a P3 and taken off the stopper list, as PM will now start. However, it is not fixed as PM with a NFS home dir will not be able to get the gconf keys and so some functionality will o longer work, such as saving Window size, default category and so on. Padraig has attached a simple test python program to 7852 which demonstrates the gksu issue independently of PM and hopefully Ghee can investigate.

Can you respin the webrev and put in as defaults the settings delivered in packagemanager-preferences.schemas.in

The gate still appears to be closed for putbacks (tip is at 1000 Wed Apr 01 07:48), so we will just queue them up for now.

JR

Michal Pryc wrote:
Padraig O'Briain wrote:
This will just have the effect that a user with NFS mounted home directory will not be able to update GConf values.

Should the default values being used be the same as we set in the delivered schemas file?

Good question. I have no strong opinion about this. I have made the int to be -1 as this means that they were not delivered through the gconf and the app's defaults this to the first elements in the treeview etc..

Michal


Padraig


On 04/02/09 15:19, Michal Pryc wrote:
Hello,

The webrev:
http://cr.opensolaris.org/~migi/7852_pm_fails_to_start/

Fixes bug:
http://defect.opensolaris.org/bz/show_bug.cgi?id=7852

How to test:
The easiest way I found is to:
 $ pfexec su
 $ mv /usr/lib/gconfd-2 /usr/lib/gconfd-2.orig

Run packagemanager.

 $ mv /usr/lib/gconfd-2.orig /usr/lib/gconfd-2

The problem with gconfd not running is not gone and we do have bug there, but this webrev solves the problem when PM was failing to start if for some reason gconfd is not running. We are defaulting the values in that case and the PM is working fine even if the gconfd is not running.



_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to