Padraig O'Briain wrote:
Looks good to me.
I believe that this implements the rules listed in comment #11 of the bug.
Padraig,
Yes. I found one corner case where this was not working and I did spin
new webrev:
http://cr.opensolaris.org/~migi/7037_gui_to_cut_category_path_v3
The difference is just in the file:
http://cr.opensolaris.org/~migi/7037_gui_to_cut_category_path_v3/src/gui/modules/misc.py.wdiff.html
107 + # Only three parts "part1/special/part2"
108 + return pkg_name + converted_name
The problem was when the pkg name consisted of three parts only and the
middle one was special, then we were returning only last two parts:
firefox/plugin/flash -> plugin/flash
instead of:
firefox/plugin/flash -> firefox/plugin/flash
Michal
Padraig
On 04/02/09 11:25, Michal Pryc wrote:
Hello,
The webrev:
http://cr.opensolaris.org/~migi/7037_gui_to_cut_category_path_v2/
Fixes bug:
http://defect.opensolaris.org/bz/show_bug.cgi?id=7037
The implementation will:
- leave the package names if they consists of less then three parts.
Example:
"virtualbox/kernel" -> "virtualbox/kernel"
"openoffice" -> "openoffice"
- cut all but three parts if the package is in the "special"
category, currently there are two special categories "locale" and
"plugin"
Example:
"apps/office/openoffice/locale/pl_PL" -> "openoffice/locale/pl_PL"
"web/mozilla/firefox/plugin/flash" -> "firefox/plugin/flash"
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
