Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-7878-v1/
Bug:
http://defect.opensolaris.org/bz/show_bug.cgi?id=7878
token_byte_offset file not correctly sorted
This doesn't have a test case currently because it's not currently
feasible. I've filed bug 8004 to track the need. Notice that anything
that caused a regression in this area would hit the RuntimeError in
write_main_dict_line. I've also noticed that this change seems to make
indexing go a bit slower, though not in the area where the code change
happens. Bug 8003 is tracking various possible speed improvements for
indexing. I'm hoping to have a few of those in before the 16th,
depending on how much performance is clawed back.
modules/indexer.py:
lines 395-396: missing space after ':'? Maybe it would be good to
put quotes or something around the '%s' to make it obvious what the
token value is (in case it's a space, etc.).
modules/search_storage.py:
line 289: please use " instead of '
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
