On Fri, Apr 10, 2009 at 04:25:41PM -0500, Shawn Walker wrote: > Greetings, > > The following webrev contains fixes for the following issues: > > 7908 publishing api and tools should use os.stat not os.lstat for file > size > > webrev: > http://cr.opensolaris.org/~swalker/pkg-7908/ > > Change Summary: > * changed misc.get_data_digest and actions/generic pkg.size calculation > logic to use os.stat instead of os.lstat since actual data size is > needed in both cases, and so symbolic links must be followed. > > * Added unit test to verify that "add file" succeeds when the specified > local file to publish is a symbolic link to a file instead of the actual > file (previously this would cause pkgsend to hang when attempting to > publish a file using /dev/null or a link to a file). > > * Removed unnecessary pkg.size calculation logic in pkgsend and > simplified add subcommand logic.
This looks fine to me. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
