+1
JR
Padraig O'Briain wrote:
I have respun the webrev http://cr.opensolaris.org/~padraig/ips-8264-v2/.
Padraig
On 04/20/09 15:08, jmr wrote:
Padraig looks fine.
Low risk, high impack, simple change to the error handler to ensure
we do no interpret anything such as < > in the outputted error as
markup, which was causing the problem.
One minor nit the title is wrong in updatemanager.py
1490 + title = _("Package Manager") -->
Update Manager
I'd like to see this webrev landed for B4.
Post 2009.06 we should move the _error_occurred() handler into
gui.misc in the follow on webrev you mentioned below.
JR
http://developers.sun.com/solaris/
Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-8264-v1/, fixes
8264 Error dialog text missing when an incorrect repository URL is
specified
8290 UpdateMananger and PackageManager calls non-existent function
The fix for 8264 is to call gtk.MessageDialog.set_property('text',
error_msg) instead of
gtk.MessageDialog.set_markup(serror_msg). This ensure that the
correct text is displayed.
The fix for 8290 is to ensure that functions which call be called
are defined.
We will refactor the code so that there is only one error_occurred
function, in gui_misc. That will be in a subsequent webrev.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
