Hi Padraig. I tested your patch and it works as expected. I do have a question, however: If your fix causes the items (at least cut, copy, and paste) in the Edit menu to no longer be specialized for the search entry, would it be worth making those menu items more consistent with the equivalents in other Gtk+ apps? In particular:
1. The standard keyboard shortcuts (Ctrl+X, Ctrl+C, Ctrl+V) should be displayed for each menu item. 2. Copy should be available whenever text is selected (including text outside of the search entry, such as the text on the pages in the notebook. 3. Paste should be available only if there's text in the clipboard. If these changes are worth making, but outside of the scope of 8306 & 8585, let me know and I'll file a new bug. Thanks! Take care. --joanie On Fri, 2009-05-01 at 14:53 +0100, Padraig O'Briain wrote: > The webrev ,http://cr.opensolaris.org/~padraig/ips-8553_v2/, fixes > 8306 packagemanager segfaults > 8585 Traceback when paste menu item is chosen > > The fix removes all references to the clipboard from packagemanager. We > use standard gtk.Entry functions to cut, copy and paste. > This will fix 8306 as the code in which the segfault occurs is no longer > executed. > > Padraig > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
