On Fri 01 May 2009 at 06:50PM, Danek Duvall wrote:
> On Fri, May 01, 2009 at 06:41:37PM -0700, Dan Price wrote:
>
> > http://cr.opensolaris.org/~dp/pkg-src-cleanup/
>
> I'm not sure that "looks good" is really necessary. Make noise only when
> things go wrong.
Fixed.
> Can you skip the chdir() and just reference the file with "extern/"
> prepended?
Ok, a new review posted.
> Perhaps "extern" could be "download"?
I picked extern because it's not strictly a place just for downloads--
we also unpack and build there. Do you feel strongly that it should
be 'download'?
> "digest(1)" -> "digest command"?
Fixed.
-dp
--
Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
