Danek Duvall wrote:
http://cr.opensolaris.org/~richb/pkg-6088-v1/
line 106: space after the comma. Also, is "p" really necessary here? I
think you could pass None like we do for directories, since there's nothing
in the archive that gets read.
You're right. It's not needed. Changes to None.
You'll also need to update the copyright date.
Okay.
Shawn Walker wrote:
line 104: if p.type in ("s", "l"): instead?
So changed.
New webrev at:
http://cr.opensolaris.org/~richb/pkg-6088-v2/
Thanks.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
