Dan Price wrote:
On Thu 07 May 2009 at 12:56AM, Shawn Walker wrote:
Dan Price wrote:
Here is my first cut at the zones + ssl repo = problems bug.
Please take a look. There is still some debug stuff in there, but
I want feedback on the approach. Many thanks to Bart who helped
me work out some somewhat ugly but hopefully low-risk changes to our
python to make this work more elegantly.
http://cr.opensolaris.org/~dp/pkg-zonefixes3/
brand/common.ksh:
lines 163, 165: do these need to use LC_ALL=C?
Ok, all fixed. Thanks for the comments.
Webrev is reposted with:
- Your comments fixed
- Commenting improved
- A bug os.abspath --> os.path.abspath fixed
- Zone attach now adds credentials if it thinks it needs to.
- A debugging hook added in the brand code to make this much
more testable (more work on this is needed but it was
really useful).
- zoneadm install now allows -k and -c arguments-- we may
as well allow these, at least for now.
The test suite is running, I think it's OK. Testing I have tried:
- I was able to install a support repo zone against a
faked up global zone running against the support repo.
- I was able to take a 2008.11 'release' repo zone and
attach -u it to a 'support' repo global zone. It
aquired the credentials, updated, and worked.
- Basic regression test of vanilla zone install on vanilla gz.
I'm going to bed, in hopes of making an early start tomorrow. More
testing is surely needed.
Please review if you can.
Dan,
I reviewed the zones-related files and they seem ok to me. I don't know
enough to review the other files. I did have one comment. In
src/brand/attach the code at 519, 520, 525 and 526 is reaching into
the zoneroot for a zone thats already been installed and in use. Since
this could be a security issue, I think you should validate that these
paths are valid and aren't symlinked someplace they shouldn't be.
Thanks,
Jerry
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
