(This is for after OpenSolaris 2009.06)
Brock Pytlik wrote:
Danek Duvall wrote:
On Thu, Apr 23, 2009 at 12:59:41PM -0700, Rich Burridge wrote:
http://cr.opensolaris.org/~richb/pkg-4178-v1/
This looks fine, except that the change to the PlanCreationException
constructor is not a compatible change. You'll either need to do all
the
stuff associated with that, or not change the name of the argument.
Brock
or Shawn should weigh in on this, I think.
Danek
Actually, I'd say that the change to the argument name in __init__ is
fine since we're not expecting clients to be constructing api_errors,
just handling them (for now at least). Changing the variable name that
the class uses, since it's not private/name-mangled, bothers me more
since, in theory, a client could be pulling info out of that variable
directly. So, if it remained self.unfound_fmris in api_errors.py, I
would have no objections at all to the wad. As it is, it is an
incompatible change, but one I'm not too worked up about. If it was
me, I'd do the change in api_errors after the release just to be safe,
if you're going to land this, please triple check that the gui code
isn't touching self.unfound_fmris anywhere (which it has a right to do).
Finally getting back to this one. New webrev (with
self.unfound_fmris untouched in api_errors.py) at:
http://cr.opensolaris.org/~richb/pkg-4178-v2/
Thanks.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
