Danek Duvall wrote:
On Tue, May 12, 2009 at 03:44:57PM -0700, Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-8865-v1/
You could use self.attrlist(), which might make things a little nicer:
try:
return [
self.__parse_category_info_helper(val)
for val in self.attrlist("value")
]
except ...
And I think you don't really need to catch ValueError anymore, now that
you're explicitly testing for the presence of the colon. And I would
probably define __parse_category_info_helper() in the context of
parse_category_info() itself, rather than making it a method on the class.
Also, fix the typo "indicies" in the bug synopsis.
Danek
So changed. Want to see it again or are you comfortable with this going
back?
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
