Hi all,
I've just added in a fix for bug #9115 to this webrev
as the fix in dependent upon the changes provided by the
other two bug fixes.
9115 Add some classifications to the 'studio' import file.
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=8970
New webrev at:
http://cr.opensolaris.org/~richb/pkg-8970-8976-9115-v3/
Just the changes to gen_os_files.py to fix bug #9115 can be found in:
http://cr.opensolaris.org/~richb/pkg-8970-8976-9115-v3/just_bug_9115
Looking for two code reviewers.
Thanks.
-------- Original Message --------
Subject: Re: [pkg-discuss] (8970) Looking for code reviewers - 15th
June 2009.
Date: Tue, 16 Jun 2009 09:51:55 -0700
From: Rich Burridge <[email protected]>
To: Danek Duvall <[email protected]>
CC: pkg discuss <[email protected]>
References: <[email protected]>
<[email protected]>
Danek Duvall wrote:
On Mon, Jun 15, 2009 at 07:30:32AM -0700, Rich Burridge wrote:
8970 Add some classifications to the 'studio' import file.
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=8970
8976 Adjust gen_os_files.py script to allow multiple classifications per
package.
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=8976
Last message:
http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/013603.html
Last webrev: http://cr.opensolaris.org/~richb/pkg-8970-8976-v1/
gen_os_files.py:
- line 104, 268: more Pythonic to say
for i, (category, sub_category) in enumerate(zip(categories,
sub_categories))
though that turns out to be a pretty long line. I personally would
probably shorten some of the variable names, but if you want to stick
with the range() call, at least get rid of the explicit starting point,
as 0 is implicit when left out.
Well as this isn't FORTRAN 66, I'd prefer to keep the existing
longer variable names. I took your suggested changes though,
and just spread them over two lines. Not too ugly.
- line 316: no need for len() calls here.
Okay. So changed.
New webrev at:
http://cr.opensolaris.org/~richb/pkg-8970-8976-v2/
I've also merged with tip and adjusted the Studio file for
both the new sunstudio12u1 and sunstudioexpress packages.
Thanks.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
