On Jun 22, 2009, at 3:44 PM, Dan Price wrote:
On Mon 22 Jun 2009 at 08:26AM, Rich Burridge wrote:
Hi all,
Still looking for code reviewers on some of these outstanding pkg
bug fixes.
Down to three webrevs now.
4134 pkg operations should report operation sizes
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=4134
7736 image plan should provide space requirements for operation
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=7736
Last message:
http://mail.opensolaris.org/pipermail/pkg-discuss/2009-June/014371.html
Last webrev: http://cr.opensolaris.org/~richb/pkg-4134-v4/
Can you include sample output, please? (In general, if you are
changing messaging, I always want sample output).
t_pkg_install.py: I'm not a big fan of interpreting informational
messages in the test suite-- could this be done as an api
test instead?
That's my fault, indeed, this should probably be done as an api test.
For some reason I hadn't suggested it.
So you've laid a bunch of track with "opstats" but we're not using
most of it, right? Wouldn't it make sense to have a
"ondisk_size()" (or ondisk_delta() perhaps) as an analog to
transfer_size()?
That sounds fine to me.
We have a package plan level "get_xferstats()". Why is this
code in imageplan? Wouldn't it be better to have
pp.get_opstats(), and then aggregate the results at the
top level?
That also seems fine.
Also, what will happen in the case of removal? Will estimated
space required be negative? Perhaps the messaging should be
smarter in that case.
Agree. I didn't think of this particular case either.
It also points out a possible flaw in the logic I had suggested to Rich.
Notably, the space required during transfer will be different than the
space required once the operation starts execution.
As such, it might be better to have an 'Estimated Transfer Space
Required' and a 'Estimated Operation Space Required'.
Thoughts?
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
