LGTM

Michal

Padraig O'Briain wrote:
New webrev, http://cr.opensolaris.org/~padraig/ips-8821-v3/, implements John's suggestions.

Padraig


jmr wrote:
Ok - looked at this and think we need Jenya's input here.

The Clear menu item currently behaves like a Delete menu item, which deletes selected text. This is consistent with other applications such as Gedit, Thunderbird and Firefox. So it would seem logical to simple rename the current Clear menu item to Delete.

The other question then is do we need a menu item that does the same as the Clear Search button? If so I think it should be named Clear or Clear Search and put underneath the Search menu item.

Jenya - what do you think?

JR

Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-8821-v2/,fixes
8821 The behavior of Clear menu item is incorrect

This webrev changes the Clear menu item to behave the same as the Clear button.

Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to