Rich Burridge wrote:
petede wrote:
Bug:

http://defect.opensolaris.org/bz/show_bug.cgi?id=9692

9692 SystemError: error return without exception set when
     trying to publish a package.

Webrev:

http://cr.opensolaris.org/~petede/gate/

Testing:
- passed the make test (sparc/x86) and also the publishing
 of the SUNWcs as per Rich's test case.

Assumption in the code is that it is actually okay to have
an empty list passed in - it just means that there is no
work to be done via the callback - and so return (0) as opposed
to -1.

With this change I was able to do a full redist_import of build #117
so it looks good to me.

Great - thanks for double checking.


What might be nice (assuming it's possible) is for a test to be added
to the test suite, that tests for this condition.

Yeap - that is the point of the change to the t_elf.py as I have
added in the explicit test for one of the binaries that caused the
issue to occur....(/usr/kernel/drv/amd64/fssnap).

And I've changed the t_elf.py to include the testing of sparc as well
(was not there earlier for this issue).

Thanks
pete



Thanks.

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to