I haven't had any further comments on this webrev. I just updated it to
include fixes to get distro-import to properly import SUNWpython-pycurl,
and to make sure the dependency is reflected in SUNWipkg. If no one has
anything else to add, I'll consider putting this back tomorrow.
I only looked at the metadata bits.
src/pkgdefs/Makefile
Looks like we keep the packages listed in alphabetical order so
please keep this.
src/pkgdefs/SUNWipkg/prototype
Not sure if it the current prototype is sorted by pathname but
it should be. In any case, it looks like your addition isn't
so please move this up prior to the "variant" entries.
src/pkgdefs/SUNWpython-pycurl/pkginfo
Please make the NAME value more descriptive (see pkginfo(4) for
more details) since this ends up as the package summary.
src/pkgdefs/SUNWpython-pycurl/prototype
Same comment as with SUNWipkg about sorting by pathname.
src/util/distro-import/118/common/SUNWpython-pycurl
Line 1 - That should be "package SUNWpython-pycurl" :-)
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
