Couple more follow up comments as I looked to actually make the changes
suggested.
Brock Pytlik wrote:
Danek Duvall wrote:
[snip]
manifest.py:
[snip]
- This isn't your issue, but get_variants() is defined twice in the
file.
Ok, I'll clean that up
Actually, I missed this at first but it's defined once in Manifest and
once in CachedManifest, so I think both should stay.
[snip]
base.py:
[snip]
- line 170: You might want to XXX-note that this is only useful when the
installed system matches delivered_files. Eventually, you'll have to
do the symlink resolution yourself.
Yep, I was aware of this issue, I'll add the XXX note.
Actually, I don't think I will need to do the symlink resolution, in
this context. These are reference real files in the proto area(s) and on
disk. It would seem to me that we can actually rely on realpath and
normpath here. For doing the resolution against packages that actively
being published, I agree and know that eventually we'll need to deal
with that.
[snip]
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
