LGTM
Michal
Padraig O'Briain wrote:
This looks good to me.
I have reviewed the code with John a few times and am happy with it.
Padraig
On 07/06/09 17:55, jmr wrote:
Another webrev to apply cleanly against the current gate:
http://cr.opensolaris.org/~jmr/pm_9710_incremental_results_06Jul_550pm/
9710 PM search should return results incrementally
JR
jmr wrote:
Joanie - here is a follow up webrev that cleans up some of the logic
and removes some duplication. It doesn't address your focus issue ,
this will be handled separately.
Padraig has a proposal to give the user a Ctrl-L option to move
focus to the list, if we stick with focus remaining in the Search
field after search has completed (9858 Focus not in package list
after search). We will also ensure that during search the keyboard
keys are disabled (9859 Focus in PM can still be changed via
keyboard during a search).
webrev:
http://cr.opensolaris.org/~jmr/pm_9710_incremental_results_06Jul_515pm/
9710 PM search should return results incrementally
Thanks,
JR
Joanmarie Diggs wrote:
Hi John.
On Fri, 2009-07-03 at 17:19 +0100, jmr wrote:
Hi - here is a webrev to provide incremental search results, in
the same fashion as the CLI. There is still a pause for some
searches before getting any output, but we are just waiting for a
response from the server and there is nothing we can do on our
side about that.
Not ideal, but understood.
Joanie hopefully this should improve the user experience.
It does as far as I'm concerned. :-) Especially on the longer
searches.
Thank you!!
I am only hooking in the accessibility info to the results when
we have the full list (same as we do now) for performance reasons
hopefully this is ok.
I tested it with Orca (moving focus to the list of results after it
had
been fully populated) and the results were presented correctly. I
haven't yet found a way to move focus into the list of packages
during a
search. So I suspect that no ATs will be asking for accessibility info
prior to your having the full list. If I discover otherwise, I'll let
you know. :-)
Take care.
--joanie
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
