On Wed, Jul 08, 2009 at 09:15:43PM -0500, Shawn Walker wrote: >> The new webrev is here: >> >> http://cr.opensolaris.org/~johansen/webrev-9929-2/ > > Overall, looks fine. > > Although, a test case would be nice, I swear we used to have one.
I thought we used to have one too. The test I added is slightly more involved: It installs the package, stops the depot, uninstalls the package, and then re-installs the package. This ensures that we can install and uninstall as long as we have manifest on disk and bits in cache. I'm not going to bother with updating the webrev since the test case is trivial. I'm re-running the full test-suite just for my own sanity. After that's finished, I'll push, unless anyone has further objections? -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
