Well I think it looks correct, but since I suggested the changes, that
probably doesn't count for much. 8-)
-alan-
Rich Burridge wrote:
>
> Hi,
>
> Still looking for a code review for this one.
>
> Thanks.
>
>
> -------- Original Message --------
> Subject: [pkg-discuss] Code review: bug #9740 - Convert dependencies
> in X IPS packages to depend_path style
> Date: Mon, 29 Jun 2009 13:22:07 -0700
> From: Rich Burridge <[email protected]>
> To: pkg discuss <[email protected]>, Alan Coopersmith
> <[email protected]>
>
>
>
> Hi,
>
> Looking for a code review for the fix for bug #9740
>
> http://defect.opensolaris.org/bz/show_bug.cgi?id=9740
> Convert dependencies in X IPS packages to depend_path style
>
> Webrev is at:
>
> http://cr.opensolaris.org/~richb/pkg-9740-v1/
>
> Local (internal) repository of a "117/redist_import" at:
>
> http://stard.sfbay.sun.com:29740
>
> The errs.import file from publishing these packages is at:
>
> http://cr.opensolaris.org/~richb/pkg-9740-v1/errs.import
>
> Lines of interest in errs.import:
>
> * i386/SUNWxorg-mesa, i386/NVDAgraphics:
> replace depend SUNWxwplr
> with depend_path /var/svc/manifest/application/opengl/ogl-select.xml
> Lines: 384627 and 378751
>
> * common/SUNWxorg-server, common/SUNWxvnc:
> replace depend SUNWxorg-xkb
> with depend_path /usr/X11/lib/X11/xkb/rules/base
> Lines: 323131 and 325559
>
> * common/SUNWxorg-server:
> replace $(i386_ONLY) depend SUNWxsvc
> with $(i386_ONLY) depend_path /platform/i86pc/kernel/drv/xsvc
> Line: 323129
>
> * common/SUNWxwinc:
> replace depend SUNWhea
> with depend_path /usr/include/sys/types.h
> Line: 326297
>
> * common/SUNWavahi-bridge-dsd:
> replace depend SUNWvncviewer
> with depend_path /usr/bin/vncviewer
> Line: 37690
>
> * common/SUNWpciaccess
> replace depend SUNWhwdata
> with depend_path /usr/share/hwdata/pci.ids
> Line: 231682
>
> Thanks.
>
>
--
-Alan Coopersmith- [email protected]
Sun Microsystems, Inc. - X Window System Engineering
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
