On Wed, Jul 22, 2009 at 09:30:40PM -0500, Shawn Walker wrote: > http://cr.opensolaris.org/~swalker/pkg-9025/
Looks good, but in the new write code, you're modifying the pkg_names parameter, which seems a bit sketchy to me. As far as I can tell, in the old code, you deliberately didn't modify it. But maybe it explicitly doesn't matter? If so, then I'd mention in the docstring that pkg_names will be modified. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
