On Mon, Aug 03, 2009 at 05:08:49PM -0500, Shawn Walker wrote: >> Danek proposed we raise an exception here instead, and I've followed up >> with some additional comments. What do you think of that approach? > > It would solve the GUI case and eliminate my concerns about the > ProgressTracker.
Ok. I discussed this with Danek earlier this afternoon. Since the level of detail lavished on this relatively small portion of the code is starting to become silly -- especially given all the other tasks we have to accomplish -- I'm going to punt, at least for now. I'm going to leave the code as is, but I'll file a bug to change our assertion handling to use a customized and more detailed exception. When we have more time, or this becomes higher priority, we can revisit this chunk of code. There's some question as to whether we even need these assertions, since they only exist to make sure that our accounting isn't creative. Even if the numbers we report are wrong, the client could still successfully perform a download and install. That said, the fact that we've hit this code a bunch recently has helped improve how we interface with pycurl's progress tracking interface. I've filed 10437 to track this. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
