On Tue 25 Aug 2009 at 06:56PM, Jan Hnatek wrote:
> Thanks, updated webrev is
> http://cr.opensolaris.org/~hnhn/pkg-10903-v2/
Jan,
The correct comment format is:
<bugid> <summary>
So:
10903 add SUNWttf-kacst to lang-support-arabic
Also, can you post somewhere the diffs against the earlier
111/common/LangSupport?
This is otherwise kind of hard to review.
-dp
> hnhn
>
> [email protected] wrote:
> >>I'd like to ask for review of:
> >>http://cr.opensolaris.org/~hnhn/pkg-lang-support-arabic/
> >>
> >>Installing 'lang-support-arabic' should also install
> >>SUNWttf-kacst.
> >
> >The fix looks fine but as SUNWttf-kacst only came into build 120, you
> >want to make a change to a new file,
> >src/util/distro-import/120/common/LangSupport. The correct way to do
> >that is use "hg cp"
> >
> > $ cd src/util/distro-import
> > $ hg cp 111/common/LangSupport 120/common/LangSupport
> >
> >and make the change to the latter.
> >
> >>As this is my first submission, I'd be happy for any
> >>guidance (should I open a CR in bugzilla for this?).
> >
> >Yes, please open a bug in Bugzilla under opensolaris/packaging.
>
> --
> Jan Hnatek
> [email protected]
> _______________________________________________
> pkg-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
--
Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
