Ric Aleshire wrote: > Dan Price wrote: > > On Tue 25 Aug 2009 at 10:06AM, Ric Aleshire wrote: > > > >> I'm looking for a review, and for a volunteer with commit access to do > >> the push: > >> http://cr.opensolaris.org/~rica/pkg-10837/ > >> 10837 ipkg zone creation will always warn after changeset 7bdf8c791f04 > >> > > > > Why not: > > > > is_brand_labeled() { > > brand_labeled=0 > > brand=`/usr/sbin/zoneadm -z $zonename list -p | awk -F: '{print > > $6}'` > > if [[ $brand = "labeled" ]]; then > > brand_labeled=1 > > fi > > } > > > > Using double brackets makes ksh{88,93} do the right thing. > > Well, that works - thanks. Updated webrev is here: > http://cr.opensolaris.org/~rica/pkg-10837-v2
BTW: It may be nice to test such changes against ksh93 -n <scriptname> # (note that this will only warn about POSIX stuff and will not enforce any ksh93-specific features) - the script fragment has two bugs: 1. the "=" operator is obsolete, please use "==" instead (e.g. if [[ $brand == "labeled" ]]; then ...) 2. please replace the `...` with $(...) ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) [email protected] \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 3992797 (;O/ \/ \O;) _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
