Mike Gerdts wrote:
On Thu, Aug 27, 2009 at 10:07 PM, Nicolas
Williams<[email protected]> wrote:
On Thu, Aug 27, 2009 at 09:19:08PM -0500, Mike Gerdts wrote:
http://mail.opensolaris.org/pipermail/pkg-discuss/2009-August/032980.html
Here's my starting point with profiling "pkg search -l ls":
...
667 for line in self._file_handle:
668 res = line.split(" ")
669 token = self.__unquote(res[0])
670 offset = int(res[1])
671 self._dict[token] = offset
In other words, each line of code between 668 and 671 takes an average
of 4.5 seconds to execute. It is parsing this file:
As I said, LISP^WPython programmers know the value of every expression...
Indeed. Can we throw Java programmers in there too?
Or sometimes, they're benchmarking on different platforms. I applied
this fix to my desktop machine (aka, the machine I use for
benchmarking), which is an intel box and saw no noticeable speed up. As
others have pointed out, we know we have lots of performance improvement
to do, especially on sparc.
Since there's been much discussion of a binary format vs a text one,
I'll provide my explanation. Text files are easier to debug. Given the
resources available, that seemed like a reasonable tradeoff. At some
point, we can move to a binary format. I question whether we're ready to
make that move yet, but seeing a dramatic speedup across platforms would
make me more interested in it.
All that said, I'd love to see this fix get integrated since it offers a
substantial speed improvement on sparc. My thanks to you Mike for doing
all the work to get this ready, I really appreciate a contribution of code.
[snip]
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
