Looks good to me.
Padraig
On 09/09/09 08:42, jmr wrote:
Respun to remove the 16 and one pylint warning.
http://cr.opensolaris.org/~jmr/pm_11215_list_toggle_selection_09Sep_840am/
11215 PM Allow toggle of select all from main list header
JR
Padraig O'Briain wrote:
This looks good to me.
Just one comment:
The 16 on line 1015 is not necessary as that is the default for size
in get_icon.
I know it does not reduce the number of lines but it removes 4
characters.
Padraig
On 09/08/09 16:08, jmr wrote:
Forgot to add the selection.png icon in this latest webrev,
corrected at:
webrev:
http://cr.opensolaris.org/~jmr/pm_11215_list_toggle_selection_08Sep_410pm/
11215 PM Allow toggle of select all from main list header
JR
jmr wrote:
Padraig pointed out to me that the busy cursor code I put in is not
functional, so I re worked this a little to ensure its set during
the potentially time consuming operation of toggling Select All on
a category, such as All Categories.
webrev:
http://cr.opensolaris.org/~jmr/pm_11215_list_toggle_selection_08Sep_330pm/
11215 PM Allow toggle of select all from main list header
JR
jmr wrote:
Hi, from the US usability study here's a webrev to give users
easier access to Select All/ Deselect All. They can just click on
the main list header selection column and instead of sorting the
selections if now toggles them all on/ off.
Note: the selection icon is just a place holder for now, but it
looks ok in the various themes.
webrev:
http://cr.opensolaris.org/~jmr/pm_11215_list_toggle_selection_07Sep_340pm/
11215 PM Allow toggle of select all from main list header
JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
