This works for me.
It looks good to me.
Padraig
On 09/09/09 15:03, jmr wrote:
Please use this webrev:
http://cr.opensolaris.org/~jmr/pm_11218_statusicon_tooltip_09Sep_3pm
JR
jmr wrote:
Thanks Padraig, new webrev with changes commented below:
webrev:
http://cr.opensolaris.org/~jmr/pm_11218_statusicon_tooltip_09Sep_255pm/
JR
Padraig O'Briain wrote:
On 09/09/09 08:47, jmr wrote:
Padraig O'Briain wrote:
I am unable to get the tooltip to appear.
Padraig - that's strange:
|*GDK_MOD2_MASK
<http://www.ongs.co.jp/projects/highstandard2/docs/jp/co/ongs/gnu/gdk2/GdkModifierType.html#GDK_MOD2_MASK>*|:
the fifth modifier key (it depends on the modifier mapping of the X
server which key is interpreted as this modifier).
Explicitly checking for Ctrl, Shift, Alt and any Button press and if
this is the state just returning.
I am just checking for event.state and if its set in anyway then I
don't show the tooltip. Not sure why you are seeing this modifier.
Can you comment out the event.state check and see if you get the
tooltip.
I do then see the tooltip.
Thanks,
JR
When I print out event.state in
__on_applicationtreeview_motion_events I get
<flags GDK_MOD2_MASK of type GdkModifierType>
Some comments on code:
The variable tip on line 2218 is unused.
Removed
Is if statement at line 2221 correct? What happens if info[1] is
None?
Changed
Is line 2229 necessary? You seem to ensure that path is not None
before calling the function.
I know it it not relevant to this webrev but the references to the
variable self.a11y_categories_treeview should be removed. This
should have been done as part of fix
for 10401.
Removed
Should the strings in the tooltip be the same as what we put out
for the accessible descriptions in __set_accessible_status?
Yep changed
Line 2269 should be removed.
I know it is not part of this webrev but line 2270 makes me
nervous. What is the purpose of this line?
We need to set the cursor on the selected row in order to locate the
popup beside the name cell of the row when the user presses
Shift+F10. As it is the users intention to get information on the
selected row I see no problems with this approach.
JR
Padraig
On 09/08/09 15:05, jmr wrote:
Joanie - we are hacking this to get the Status cell tooltip. The
correct way to do this is to use the Tooltips property of the
TreeView and have it pull the data from a hidden row, but as I
said below this means its a row tooltip as opposed to a cell
tooltip, which is not what's required.
webrev:
http://cr.opensolaris.org/~jmr/pm_11218_statusicon_tooltip_08Sep_3pm/
11218 - PM show tooltip on status icons in main list view
I've tried various ways to bring up the tooltip with Ctrl-F1 and
none work quite the way I want (tooltip will come up but its
located on the mouse position not the cell and I have no way to
force the Tooltip to do this other than rewrite the Tooltip class
itself). So I think the best solution is if we want a Status
tooltip is to provide it only for mouse over and disable it on
keyboard for Ctrl-F1.
This is just a hint for novice users so I don't feel too bad
about turning it off for keyboard users and for Orca users they
will get the status read out to them, so its redundant in this
case. Also this information along with the status icon is now
displayed in the new Details panel Padraig put back yesterday.
Let me know what you think.
JR
Joanmarie Diggs wrote:
Hi John.
The following makes no difference as far as Orca users are
concerned
because the status icons already have accessible image
descriptions.
(read: I don't care one way or the other; I wasn't sure if you
would or
not, so fwiw....)
* If you use the keyboard to give focus to a table cell
containing a
status icon and press Ctrl+F1, the appearance of the tooltip
associated
with the icon in that cell is not toggled. According to the
GNOME HIG
guidelines [1], it should be.
* You are apparently inheriting some of the built-in Gtk+
support for
Ctrl+F1 because pressing it can cause your tooltips to no longer be
displayed near the icon -- and in at least one case to no longer be
displayed at all.
Steps to reproduce:
1. Select an item in the package list.
2. Hover the mouse pointer over a status icon.
(Tooltip appears near that icon as expected.)
3. Press Ctrl+F1.
(Tooltip jumps down to just beneath the split between the
package list and the notebook. Hovering the mouse over other
status icons
causes the tooltip to be displayed in this new location.)
4. Click on one of the categories on the left.
5. Hover the mouse pointer over a status icon.
(Tooltips don't appear at all, whereas prior to pressing
Ctrl+F1 you
could select a category and hover the mouse over a status
icon in the
non-focused list of packages and get the appropriate tooltip.)
Pressing Ctrl+F1 again will cause the tooltips to reappear and be
displayed in the location you intend.
Also please note that Ctrl+F1 currently works quite nicely in
the other
widgets in PM (e.g. toolbar buttons, Search entry). This existing
functionality is handy for Orca users (and others who cannot use a
mouse) who wish to obtain more information about a given widget.
There's
just something about the package list which is not quite right
in this
regard. <shrugs>
[1]
http://library.gnome.org/devel/hig-book/stable/input-keyboard.html.en
Take care.
--joanie
On Mon, 2009-09-07 at 19:10 +0100, jmr wrote:
Hi - here's a webrev to add tooltips to the status icons in the
main list view in PM to help users understand what they mean,
given feedback from xDesign and usability studies.
webrev:
http://cr.opensolaris.org/~jmr/pm_11218_statusicon_tooltip_07Sep_650pm/
11218 - PM show tooltip on status icons in main list view
JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
