I'm looking for code review and test advice for > 6572 ability to trigger repository index refresh desired > 6573 ability to control publication refresh-index behaviour desired
http://cr.opensolaris.org/~mjnelson/webrev.pkg-index-control/ For 6572, I chose "rebuild-index" for the pkgsend subcommand. That seemed natural to me, but if folks prefer, I can easily change it to "refresh-index." The "refresh" term just shows up a lot already. I have tested both fixes using FileTransaction and HTTPTransaction, using the work-in-progress ON IPS build and my updated SUNWipkg, contrasting the behavior with and without the new pkgsend functionality. I know I still need to do some error case testing, and will be tackling that today. What do these call for in the way of automated testing? The existing pkgsend CLI tests are pretty much black box; do I simply need to validate that using the new pkgsend subcommand, and the new option to the close subcommand, returns successfully? Or do I need to also validate that the indices are/are not rebuilt? If the latter, can somebody point me to some examples or other information to help? Thanks. --Mark _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
