I'll wait a day in case anyone else wants to look at this (or let me
know that they want to), otherwise I'lll put it back.
Brock
Danek Duvall wrote:
Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-1059-v1/
api.py:
- line 1064ff: There's not much meat in bug 10365, so I'm guessing that
this hunk fixes it by making sure that all values are yielded before
the exception is raised? Or is there something else that's causing the
problem?
Yep, that's right. I'll add more detail to the bug.
- line 1104, 1108: you're changing the return signature of this method,
which means that API clients will need to change. Looks like the two
clients in the gate ignore query_num, so perhaps it can slip under the
radar, but I wanted to make sure you were doing this deliberately.
I am doing it deliberately. I can bump the api if needed, but since no
consumers of search currently look at the query num, I thought it'd be
ok to just leave it alone.
client/query_parser.py:
- line 95: two spaces after "return"
Fixed.
- line 416: should this list include "directory"?
Yeo, it should. Sorry, I thought I'd caught all the actions with paths.
- line 422: it might be clearer if you just rstripped img_root of "/"
characters
Ok.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
