Michal Pryc wrote:

> http://cr.opensolaris.org/~migi/integrate_ldtp_v5/

This seems okay to me, though the return value of run_cmd() is always 0, so
there's no need to return anything, or test the return value in its
callers.  Also, is the "make_done" file really necessary?  Can't you just
run "make install" instead of the separate "make" and "make install" steps?

Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to