Danek Duvall wrote:
Brock Pytlik wrote:

http://cr.opensolaris.org/~bpytlik/ips-8868-v1/

So like you said, this looks pretty familiar.  Looks fine to me, though I
noticed a bug with single-line descriptions, which is fairly obvious when
you actually run the code, and that is the way padding is done -- there's
always a pad added, regardless of whether there's more than one line of
description or not.  I changed my local copy to simply look more like

    res = pad.join(res)

and it seems to work both for single and multi-line descriptions.  I've no
idea why I had it the way I had it.

Danek
Ah, I see now why i didn't catch this when testing visually. Because the description is the last line, it doesn't look horribly wrong. I'll fix that, send it out once more in case anyone else wants to look at it, and if no one comments, put it back when I'm back on Friday.
$ pkg info -r SUNWzsh
          Name: SUNWzsh
       Summary: Z shell (zsh)
      Category: System/Shells
         State: Not installed
     Publisher: ipkg
       Version: 4.3.9
 Build Release: 5.11
        Branch: 0.123
Packaging Date: September 11, 2009  9:38:14 PM
          Size: 4.58 MB
          FMRI: pkg://ipkg/[email protected],5.11-0.123:20090911T213814Z
   Description: Z shell (zsh)
$ pkg info -r pkg://ipkg/entire
          Name: entire
       Summary: Build 123 entire incorporation
         State: Not installed
     Publisher: ipkg
       Version: 0.5.11
 Build Release: 5.11
        Branch: 0.123
Packaging Date: September 11, 2009  9:38:29 PM
          Size: 0.00 B
          FMRI: pkg://ipkg/[email protected],5.11-0.123:20090911T213829Z
Description: This package constrains package versions to those for build 123. WARNING: Proper system update and correct package selection depend on the presence of this incorporation. Removing this
                package will result in an unsupported system.

Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to