I have respun this webrev, http://cr.opensolaris.org/~padraig/ips-12110-v2/.
Padraig
On 10/27/09 11:50, jmr wrote:
Padraig - looks fine except:
3801 + if i ==
self.repo_combobox_all_pubs_index:
3802 + break
This makes the code fragile if we ever put "All Publishers" before the
end of the publisher combo list. I would remove this and the need to
increment i goes away also. The code will now work happily regardless
of where "All Publisher" appears in the list.
JR
Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-12110-v1/, fixes
12110 Selections while performing search for "All publishers" doesn't
enable install/update or remove buttons
The fix is to correctly determine whether there are packages to
install or remove when in All Publisher mode.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
