Looks fine and agree that using "0" is clearer on the intent. Tested and
runs fine checked on amp and entire, no size displayed in Details.
+1
JR
Padraig O'Briain wrote:
Respun the webrev, http://cr.opensolaris.org/~padraig/ips-12105-v2/.
Padraig
On 10/27/09 12:02, jmr wrote:
Padraig - I would prefer if you put a stub "-1" into the text["size"]
when local_info.size == 0 and test for this string as opposed to
catching the key error in set_package_details_text(). Think its a bit
cleaner and clearer.
JR
Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-12105-v1/, fixes
12105 Package with dependencies only should not show size in details
We no longer display the size for packages whose size is 0.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
