Padraig - here is a webrev to address the Proceed button issue:

http://cr.opensolaris.org/~jmr/pm_12457_webinstall_proceed_button_4Nov_745pm/
12457 Inconsistency with icons in buttons

I have separated out this code into the gui misc module so we can reuse it if need be. I understand your concerns but this is to work around an api limitation in Gtk, which we have had to do already, for instance in PM when we had to dig into the Status Bar internals to enable markup in the Status Bar.

Gtk does not allow you to change the label of a button with a stock icon. The only way to do it is to dig into the buttons internals, fetch the label and set it. There is a way to change the label for all stock items for a particular type, but that is not what is needed here. The code checks at each point as it digs into the control, falling back to the default which in this case would be a button labeled Ok if there are any issues, such as a change in the internal layout of the Gtk.Button widget.

JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to