Reviewed this again with John and it looks good to me.
Padraig
On 11/09/09 19:21, jmr wrote:
Thanks Padraig,
Changed the text.
On testing found some corner cases with multiple new pubs, canceling
in the middle of the addition and then not being able to continue when
clicking Proceed again. Issues in Repository.py not handling
CatalogRefreshException output and the need to reset the api, reparse
the p5i file and regenerate the tasks list, as some of them may have
completed before the cancel operation. Changes in webrev below:
http://cr.opensolaris.org/~jmr/pm_12178_export_p5i_9Nov_630pm/
12178 PM support Export Selections in .p5i format
12558 Webinstall Disabled Pub UI review
JR
Padraig O'Briain wrote:
Should "Click proceed..." be "Click Proceed..."?
Padraig
On 11/08/09 21:02, jmr wrote:
New webrev, I have also included 12558 to cover the Webinstaller UI
review with xDesign.
http://cr.opensolaris.org/~jmr/pm_12178_export_p5i_8Nov_9pm/
12178 PM support Export Selections in .p5i format
12558 Webinstall Disabled Pub UI review
JR
John Rice wrote:
Thanks Padraig, comments below.
JR
Padraig O'Briain wrote:
There are trailing spaces at the end of line 370 in
packagemanager.py.
Will remove.
Should the strings at lines 178, 181 of webinstall.py and 725 and
728 of packagemanager.py be translated?
Nope these are the Publisher names and Package names.
The icon you use in the confirmation dialog is different from the
one used when confirming package removal and beadmin actions. is
this intentional?
Yes the removal is using a Warning, I am just giving the
information about a non destructive action, so Information seems
appropriate.
Padraig
jmr wrote:
Reviewed this with Padraig and we caught a few corner cases. I
have added a confirmation dialog which lists out the selections
you are about to export, which to some extent addresses the issue
of not having a consolidate selections view across All Publishers
at present.
http://cr.opensolaris.org/~jmr/pm_12178_export_p5i_6Nov_530pm/
12178 PM support Export Selections in .p5i format
JR
jmr wrote:
Hi - this webrev adds support to PM under File->Export
Selections, to export your selections to a .p5i file, which can
be used to install this set of packages, adding their Publishers
if required.
Once you have a .p5i you can click on it in nautilus to run PM
in WebInstall mode. You can also put the .p5i file up on a web
page, blog or irc session and users can click on it to install
the packages it specifies. The .p5i file is a recognized mime
type on OpenSolaris.
You can export selections from multiple Publishers at the same
time if you wish. You can make selections from the list view and
from search results. At the moment there is no consolidated View
for all your selections, you currently just see selections for a
given Publisher. This is something we need to look at.
http://cr.opensolaris.org/~jmr/pm_12178_export_p5i_6Nov_1pm/
12178 PM support Export Selections in .p5i format
JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
