On Tue, Nov 10, 2009 at 04:45:28PM -0600, Shawn Walker wrote: > Greetings, > > The following webrev contains fixes for the following stopper issues: > > 12596 compressed repository files not upgraded to new format > automatically > > webrev: > http://cr.opensolaris.org/~swalker/pkg-12596/ > > Summary of Changes: > > * changed filemanager to __always__ insert the requested file > regardless of whether it already exists; this ensures that files > that have the same hash name will be replaced when necessary (as is > the case for our chash for compressed gzip files that are upgraded). > Previously the filemanager would intentionally do nothing if the > file already existed for an insert() operation.
This looks fine to me. I find the variable naming in this function to be a bit confusing; insert_path and legacy_path might be better replacements for src_path and cur_full_path, but I realize you didn't write this code. I understand if you don't want to change these now. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
