Erik Trauschke wrote:
bump

Erik

Btw: this is running on several of our machines now, it would just be
nice if I wouldn't have to patch it in every time I redeploy.

On Fri, 2009-11-06 at 16:51 -0800, Erik Trauschke wrote:
http://cr.opensolaris.org/~erisch/pkg-gate1106/

respun webrev:

changed pkg_env to pkg_root
content_root now defaults to $pkg_root/usr/share/lib/pkg
content_root can be set as a relative path (then it is always located
under pkg_root) or as an absolute path.

Erik

On Wed, 2009-11-04 at 16:16 -0800, Erik Trauschke wrote:
On Wed, 2009-11-04 at 16:09 -0800, Danek Duvall wrote:
Erik Trauschke wrote:

Actually it is possible to set an environment variable on a per-instance
basis. However, this means that someone needs to set two variables in SMF
which have to match up to be useful. Setting the PYTHONPATH in the method
script just takes away one possible source of failure, so you only have
to set the pkg_env variable and everything else is handled automatically.
Okay, makes sense.

If you ever elevate this to a documented interface, I'd suggest pkg_root
instead, but whatever you call it, the code looks fine.
It's funny, that was my original idea. Dan suggested something like
virtual_env but I figured it's not really virtual so I decided for
pkg_env.

It's a simple fix, I'm +1 for pkg_root.

Erik

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

+1
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to