Bart Smaalders wrote:
Some fixes to facilitate faster/simpler publication to file://
repos:
http://cr.opensolaris.org/~barts/faster-publication/
src/depot.py:
line 529: missing '.'
line 656: nit, but can you keep the keywords in asciibetical order?
general: I'm assuming this is not an option intended for use with SMF
and so was omitted from our SMF startup script and the SMF options.
src/man/pkg.depotd.1m.txt:
line 13, 14: nit, but can you keep the options in asciibetical order?
line 157: synchonously?
line 176: missing ',' at end.
line 177: catalogies?
src/modules/publish/transaction.py:
line 348: s/onlym/only./
src/modules/server/repository.py:
line 35: unused import?
line 784: parentheses to clarify the condition evaluation would be nice
line 1182: missing '.' at end
line 295: needs continuation indent
src/publish.py:
Want to see --no-catalog for close too.
src/tests/*
Really want unit test to be certain --no-catalog doesn't get broken
by future changes. Easy to do. Just use pkgsend create-repository to
create an empty repository, get the last modified time of the
$REPO/catalog/catalog.attrs file, then use pkgsend to publish to it via
file with --no-catalog, and then check the last_modified time again.
General:
Can we open a bug for http support of --no-catalog? It just needs to
do roughly the same thing that was done for X-IPkg-Refresh-Index. A
protocol rev isn't needed, since as you pointed out, the option only
affects performance. Not expecting that this wad given this is for an
immediate need.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
