Bart Smaalders wrote:
http://cr.opensolaris.org/~barts/pkgdiff/
General comments:
Why are pkgdiff and pkgmogrify in util/publish if we deliver them to
usr/bin? Is util/publish where pkgsend should be? Just curious about
where we're supposed to be putting what.
I'm generally happy with the functionality and output here. There are
further enhancements that could be made, but they're all polish, and
this is a great start.
src/man/pkgdiff.1.txt:
line 28: What about actions that don't have a key attribute?
lines 34-36, 39-40: can you indent this entire paragraph to match the
style we use in our other man pages?
line 38: indent for descriptive text doesn't match line 33
line 39: s/WIll/Will/ ?
src/util/publish/pkgdiff.py:
lines 89, 116, 160, 284, 285: extra newlines
line 236: s/ in/ in/
lines 103, 135, 156, 193, 233, 241, 251, 252, 253, 274,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
