On Tue 08 Dec 2009 at 04:34PM, Danek Duvall wrote:
> I had this out for review back in August, and for some reason didn't commit
> it. I think I took care of all relevant comments on it, but I had to do a
> little bit of merge work, so if anyone wants to take another look:
>
> http://cr.opensolaris.org/~dduvall/pkg-contents-match2/
>
> If you review it, or want to review it but don't have time right now,
> please get back to me by mid-afternoon (Pacific) tomorrow. I'll push if I
> don't hear anything, since it's really been reviewed before.
client.py:1617: Can getattr() be used here?
As I mentioned the last time this came for review, there's
significant overlap with search here. Perhaps the documentation
in the man page could somehow guide the user about when to use
contents and when search?
Otherwise, looks good to me. Many thanks, I will use this often
I suspect.
-dp
--
Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
