Rich Burridge wrote: > http://cr.opensolaris.org/~richb/pkg-12005-v2/
Please use double quotes for strings unless there's good reason to do otherwise. AFAICT, bug 9568 covers the "minor node spec required" message, and bug 6877673 covers the "missing token:" message, but what covers the "no entry found for driver" message? It would be useful to be specific, either in comments in the code, or in the bug, under what conditions each message is emitted, and thus under what conditions that snippet of code can be removed. I'd lean towards putting this in the code. line 125: you can simply do "for c in perm_str", since you only ever use n to index directly into perm_str. Otherwise, looks nice. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
