This webrev looks good to me.
Padraig
John Rice wrote:
Ok - Shawn think it best to separate out these issues:
New bug logged:
13234 PM Package Version Info failing in certain instances
I have backed out the changes to __after_get_info() and respun the
webrev for 9801:
http://cr.opensolaris.org/~jmr/pm_9801_manage_installed_packages_in_pm_10Dec_1040pm/
Can you comment on 13234 for us.
Thanks.
JR
John Rice wrote:
Shawn - its to support the Packge Verison Info we discussed before.
This was a corner case that we had not come across.
You have an installed package and want to check if its installable or
not. We run the plan and it comes back with information on what is
local, what's remote and what the plan can do. In this particular
instance, the local and remote versions are different, but the plan
and remote versions are the same. So we can tell the user they can
install the latest version.
Looking at the code should we also be checking the version, in
addtion to the build_release and branch, to establish what the user
can and cannot upgrade to? If that's the case then I will take this
bit out of the current webrev, and spin a new one for changes in
__after_get_info().
JR
Shawn Walker wrote:
John Rice wrote:
Thanks Joanie,
We are tracking the issue in 13216, I think this is another
manifestation of it. I'll get to it next week after feature freeze.
New webrev that applies against the gate, has some pylint warning s
removed and a corner case in package version that I came across in
testing. Padraig has reviewed and tested this one.
http://cr.opensolaris.org/~jmr/pm_9801_manage_installed_packages_in_pm_10Dec_10pm/
9801 PM Manage Installed Packages - webrev
13099 Add more feedback when a "View" selection produces no results
13209 PM Apply install/remove action to all selected packages
across publishers
I don't understand the build_release bit. In particular, you can't
really use that to make decisions about package information in many
cases.
What is the purpose of this particular logic?
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
